From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: VMX: Update instruction length on intercepted BP Date: Mon, 15 Feb 2010 08:48:21 +0200 Message-ID: <4B78EE35.2030507@redhat.com> References: <4B767160.4070609@web.de> <20100214075303.GF2511@redhat.com> <4B77CFD7.9080504@web.de> <20100214103445.GH2511@redhat.com> <4B77D4DE.3030602@web.de> <20100214111544.GJ2511@redhat.com> <4B77E0E2.7030704@web.de> <4B7805D2.7070602@redhat.com> <4B7826F0.8060009@web.de> <4B78286F.4000103@redhat.com> <4B782DA0.5030301@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , Marcelo Tosatti , kvm , Lucas Meneghel Rodrigues To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1025 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752064Ab0BOGsZ (ORCPT ); Mon, 15 Feb 2010 01:48:25 -0500 In-Reply-To: <4B782DA0.5030301@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On 02/14/2010 07:06 PM, Jan Kiszka wrote: > >> The autotest people (Lucas copied) are generally good at adding tests, >> so all we need to do is (a) add a test case to >> qemu-kvm.git:kvm/user/test (b) indicate to the autotest people how to >> build and run this thing. >> > I wonder if it requires a stand-alone test. So far I'm testing the guest > side via gdb installed in some Linux image. We need to interact with gdb > anyway to test guest debugging, so this would just add another instance > and some indirection (via serial console or ssh into the guest). > Scripting gdb is perfectly fine, don't know why I thought of the unit tests. These are more suitable to test the guest debugging itself. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.