public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: KVM General <kvm@vger.kernel.org>
Subject: [PATCH] qemu-kvm Set kvm_features name for kvm_cr3_cache
Date: Wed, 17 Feb 2010 18:44:12 +0100	[thread overview]
Message-ID: <4B7C2AEC.7090503@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

Hi,

Comparing the features tested for in get_para_features() with the
kvm_feature_names in target-i386/helper.c, I noticed that we didn't
list the cr3_cache feature in the real name table.

I presume this is unintentional so here's a patch to correct it.

Cheers,
Jes


[-- Attachment #2: 0000-kvm_cr3_catch-name.patch --]
[-- Type: text/plain, Size: 932 bytes --]

commit 39cb576d15a6ffbbcade3c4f282c2f3e76e3098a
Author: Jes Sorensen <Jes.Sorensen@redhat.com>
Date:   Wed Feb 17 18:03:37 2010 +0100

    Add kvm_cr3_cache to the list of KVM features.
    
    This is to match the features automatically added by
    target-i386/kvm.c:get_para_features()
    
    Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>

diff --git a/target-i386/helper.c b/target-i386/helper.c
index f9d63f6..2cd3dca 100644
--- a/target-i386/helper.c
+++ b/target-i386/helper.c
@@ -61,7 +61,8 @@ static const char *ext3_feature_name[] = {
 };
 
 static const char *kvm_feature_name[] = {
-    "kvmclock", "kvm_nopiodelay", "kvm_mmu", NULL, NULL, NULL, NULL, NULL,
+    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvm_cr3_cache",
+    NULL, NULL, NULL, NULL,
     NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
     NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
     NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,

             reply	other threads:[~2010-02-17 17:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17 17:44 Jes Sorensen [this message]
2010-02-17 21:08 ` [PATCH] qemu-kvm Set kvm_features name for kvm_cr3_cache Marcelo Tosatti
2010-02-17 21:26   ` Jes Sorensen
2010-02-17 21:35     ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7C2AEC.7090503@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox