From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch] x86: kvm: Convert i8254/i8259 locks to raw_spinlocks Date: Thu, 18 Feb 2010 11:20:35 +0200 Message-ID: <4B7D0663.70807@redhat.com> References: <20100217135901.331576359@linutronix.de> <4B7D0466.2030700@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Thomas Gleixner , KVM To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7104 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754487Ab0BRJUq (ORCPT ); Thu, 18 Feb 2010 04:20:46 -0500 In-Reply-To: <4B7D0466.2030700@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/18/2010 11:12 AM, Jan Kiszka wrote: > Thomas Gleixner wrote: > >> The i8254/i8259 locks need to be real spinlocks on preempt-rt. Convert >> them to raw_spinlock. No change for !RT kernels. >> > Last time I ran KVM over RT, I also had to convert requests_lock (struct > kvm): make_all_cpus_request assumes that this lock prevents migration. > > True. Will commit something to that effect. Meanwhile, if anyone has any idea how to kill this lock, I'd love to see it. -- error compiling committee.c: too many arguments to function