From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: qemu-kvm: do not allow vcpu stop with in progress PIO Date: Thu, 18 Feb 2010 15:24:46 +0200 Message-ID: <4B7D3F9E.1050503@redhat.com> References: <20100128190300.414710338@redhat.com> <20100128190411.495771070@redhat.com> <4B6B1D1F.1080701@redhat.com> <20100204213643.GC2766@amt.cnet> <4B6B4031.80008@redhat.com> <20100208224119.GA6516@amt.cnet> <4B710300.7090903@redhat.com> <20100209205805.GA25144@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, quintela@redhat.com, Gleb Natapov To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:49284 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751404Ab0BRNYs (ORCPT ); Thu, 18 Feb 2010 08:24:48 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1IDOm1b008728 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Feb 2010 08:24:48 -0500 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1IDOlOR030597 for ; Thu, 18 Feb 2010 08:24:47 -0500 In-Reply-To: <20100209205805.GA25144@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 02/09/2010 10:58 PM, Marcelo Tosatti wrote: > You're right... this should be enough to avoid a stop with uncomplete > PIO (and this is what happens for MMIO already). The signal will not > be dequeued, so KVM will complete_pio and exit before entering with > -EAGAIN. Please review and queue for stable. > > qemu upstream needs a bit more work. > > ------- > > Re-enter the kernel to complete in progress PIO. Otherwise the > operation can be lost during migration. > > Thanks - applied to master and 0.12. -- error compiling committee.c: too many arguments to function