* extboot: Purpose of cmd value
@ 2010-02-18 14:01 Jan Kiszka
2010-02-18 14:07 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2010-02-18 14:01 UTC (permalink / raw)
To: Anthony Liguori; +Cc: kvm
Hi Anthony,
I have to fix extboot for non-KVM usage which means pushing its
variables to writable RAM (probably some spare INT vector(s) in the
BASIC area).
In that process, I stumbled over the cmd value passed to extboot_init,
then stored in qemu_malloc'ed memory, and finally reported to the guest
side via port 0x404. It's constant so far, always 1. So there is quite a
bit unused code and data on both sides. Can we drop that?
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: extboot: Purpose of cmd value
2010-02-18 14:01 extboot: Purpose of cmd value Jan Kiszka
@ 2010-02-18 14:07 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2010-02-18 14:07 UTC (permalink / raw)
To: Jan Kiszka; +Cc: kvm
On 02/18/2010 08:01 AM, Jan Kiszka wrote:
> Hi Anthony,
>
> I have to fix extboot for non-KVM usage which means pushing its
> variables to writable RAM (probably some spare INT vector(s) in the
> BASIC area).
>
> In that process, I stumbled over the cmd value passed to extboot_init,
> then stored in qemu_malloc'ed memory, and finally reported to the guest
> side via port 0x404. It's constant so far, always 1. So there is quite a
> bit unused code and data on both sides. Can we drop that?
>
Yes, that's historic from the days when extboot also did Linux kernel
loading. I don't see a problem dropping.
Regards,
Anthony Liguori
> Jan
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-18 14:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-18 14:01 extboot: Purpose of cmd value Jan Kiszka
2010-02-18 14:07 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox