From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: extboot: Purpose of cmd value Date: Thu, 18 Feb 2010 08:07:17 -0600 Message-ID: <4B7D4995.3090908@linux.vnet.ibm.com> References: <4B7D481E.2090308@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm To: Jan Kiszka Return-path: Received: from e32.co.us.ibm.com ([32.97.110.150]:51709 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753422Ab0BROHZ (ORCPT ); Thu, 18 Feb 2010 09:07:25 -0500 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e32.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o1IE15F7015219 for ; Thu, 18 Feb 2010 07:01:05 -0700 Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id o1IE7KpE038840 for ; Thu, 18 Feb 2010 07:07:20 -0700 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o1IE9a0M023959 for ; Thu, 18 Feb 2010 07:09:36 -0700 In-Reply-To: <4B7D481E.2090308@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/18/2010 08:01 AM, Jan Kiszka wrote: > Hi Anthony, > > I have to fix extboot for non-KVM usage which means pushing its > variables to writable RAM (probably some spare INT vector(s) in the > BASIC area). > > In that process, I stumbled over the cmd value passed to extboot_init, > then stored in qemu_malloc'ed memory, and finally reported to the guest > side via port 0x404. It's constant so far, always 1. So there is quite a > bit unused code and data on both sides. Can we drop that? > Yes, that's historic from the days when extboot also did Linux kernel loading. I don't see a problem dropping. Regards, Anthony Liguori > Jan > >