From: Avi Kivity <avi@redhat.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/10] KVM: SVM: Make lazy FPU switching work with nested svm
Date: Thu, 18 Feb 2010 16:32:02 +0200 [thread overview]
Message-ID: <4B7D4F62.3010903@redhat.com> (raw)
In-Reply-To: <1266493115-28386-10-git-send-email-joerg.roedel@amd.com>
On 02/18/2010 01:38 PM, Joerg Roedel wrote:
> TDB.
>
>
...
> @@ -973,6 +973,7 @@ static void svm_decache_cr4_guest_bits(struct kvm_vcpu *vcpu)
>
> static void update_cr0_intercept(struct vcpu_svm *svm)
> {
> + struct vmcb *vmcb = svm->vmcb;
> ulong gcr0 = svm->vcpu.arch.cr0;
> u64 *hcr0 =&svm->vmcb->save.cr0;
>
> @@ -984,11 +985,25 @@ static void update_cr0_intercept(struct vcpu_svm *svm)
>
>
> if (gcr0 == *hcr0&& svm->vcpu.fpu_active) {
> - svm->vmcb->control.intercept_cr_read&= ~INTERCEPT_CR0_MASK;
> - svm->vmcb->control.intercept_cr_write&= ~INTERCEPT_CR0_MASK;
> + vmcb->control.intercept_cr_read&= ~INTERCEPT_CR0_MASK;
> + vmcb->control.intercept_cr_write&= ~INTERCEPT_CR0_MASK;
> + if (is_nested(svm)) {
> + struct vmcb *hsave = svm->nested.hsave;
> +
> + hsave->control.intercept_cr_read&= ~INTERCEPT_CR0_MASK;
> + hsave->control.intercept_cr_write&= ~INTERCEPT_CR0_MASK;
> + vmcb->control.intercept_cr_read |= svm->nested.intercept_cr_read;
> + vmcb->control.intercept_cr_write |= svm->nested.intercept_cr_write;
>
Why are the last two lines needed?
> + }
> } else {
> svm->vmcb->control.intercept_cr_read |= INTERCEPT_CR0_MASK;
> svm->vmcb->control.intercept_cr_write |= INTERCEPT_CR0_MASK;
> + if (is_nested(svm)) {
> + struct vmcb *hsave = svm->nested.hsave;
> +
> + hsave->control.intercept_cr_read |= INTERCEPT_CR0_MASK;
> + hsave->control.intercept_cr_write |= INTERCEPT_CR0_MASK;
> + }
> }
> }
>
Maybe it's better to call update_cr0_intercept() after a vmexit instead,
to avoid this repetition, and since the if () may take a different
branch for the nested guest and guest cr0.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-02-18 14:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 11:38 [PATCH 0/10] Nested SVM fixes (and Win7-64bit bringup) Joerg Roedel
2010-02-18 11:38 ` [PATCH 01/10] KVM: SVM: Don't use kmap_atomic in nested_svm_map Joerg Roedel
2010-02-18 13:40 ` Avi Kivity
2010-02-18 16:16 ` Joerg Roedel
2010-02-18 11:38 ` [PATCH 02/10] KVM: SVM: Fix wrong interrupt injection in enable_irq_windows Joerg Roedel
2010-02-18 11:38 ` [PATCH 03/10] KVM: SVM: Fix schedule-while-atomic on nested exception handling Joerg Roedel
2010-02-18 13:52 ` Avi Kivity
2010-02-18 16:24 ` Joerg Roedel
2010-02-18 11:38 ` [PATCH 04/10] KVM: SVM: Sync all control registers on nested vmexit Joerg Roedel
2010-02-18 11:38 ` [PATCH 05/10] KVM: SVM: Annotate nested_svm_map with might_sleep() Joerg Roedel
2010-02-18 11:38 ` [PATCH 06/10] KVM: SVM: Fix nested msr intercept handling Joerg Roedel
2010-02-18 11:38 ` [PATCH 07/10] KVM: SVM: Don't sync nested cr8 to lapic and back Joerg Roedel
2010-02-18 11:38 ` [PATCH 08/10] KVM: SVM: Activate nested state only when guest state is complete Joerg Roedel
2010-02-18 11:38 ` [PATCH 09/10] KVM: SVM: Make lazy FPU switching work with nested svm Joerg Roedel
2010-02-18 14:32 ` Avi Kivity [this message]
2010-02-18 16:29 ` Joerg Roedel
2010-02-18 14:51 ` Alexander Graf
2010-02-18 14:55 ` Avi Kivity
2010-02-18 16:30 ` Joerg Roedel
2010-02-18 11:38 ` [PATCH 10/10] KVM: SVM: Remove newlines from nested trace points Joerg Roedel
2010-02-18 14:33 ` [PATCH 0/10] Nested SVM fixes (and Win7-64bit bringup) Avi Kivity
2010-02-18 14:48 ` Alexander Graf
2010-02-18 14:54 ` Avi Kivity
2010-02-18 16:33 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7D4F62.3010903@redhat.com \
--to=avi@redhat.com \
--cc=joerg.roedel@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox