From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch uq/master 2/4] qemu: kvm specific wait_io_event Date: Thu, 18 Feb 2010 16:33:51 +0200 Message-ID: <4B7D4FCF.907@redhat.com> References: <20100217221439.351652889@redhat.com> <20100217221701.041682707@redhat.com> <4B7CFA6F.3080801@redhat.com> <20100218135839.GA7147@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:20321 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756060Ab0BROdw (ORCPT ); Thu, 18 Feb 2010 09:33:52 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1IEXqTe013601 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Feb 2010 09:33:52 -0500 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1IEXprP013474 for ; Thu, 18 Feb 2010 09:33:52 -0500 In-Reply-To: <20100218135839.GA7147@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 02/18/2010 03:58 PM, Marcelo Tosatti wrote: > On Thu, Feb 18, 2010 at 10:29:35AM +0200, Avi Kivity wrote: > >>> +static void qemu_kvm_wait_io_event(CPUState *env) >>> +{ >>> + while (!cpu_has_work(env)) >>> + qemu_cond_timedwait(env->halt_cond,&qemu_global_mutex, 1000); >>> + >>> + qemu_wait_io_event_common(env); >>> } >>> >> Shouldn't kvm specific code be in kvm-all.c? >> > The context is in vl.c, so don't see much gain. > ok. -- error compiling committee.c: too many arguments to function