From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][uq/master] KVM: x86: Fix eflags corruption in kvm mode Date: Sun, 21 Feb 2010 11:14:43 +0200 Message-ID: <4B80F983.7040706@redhat.com> References: <4B7EC890.8000309@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , qemu-devel , kvm , Anthony Liguori To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13070 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754787Ab0BUJOu (ORCPT ); Sun, 21 Feb 2010 04:14:50 -0500 In-Reply-To: <4B7EC890.8000309@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/19/2010 07:21 PM, Jan Kiszka wrote: > This should explain a lot of the weird breakages of upstream KVM we've > seen recently (actually we should have seen it much earlier): > > Stop translating eflags into TCG format when in kvm mode as we never > translate it back and rather sync this broken state into the kernel. > > Applied to uq/master and uq/stable-0.12, thanks (though realistically 0.12 kvm users should stick with qemu-kvm). > qemu-kvm is not affected as it has it own cpu loop - maybe the way to go > for upstream as well on the long-term. > > Or use a skeleton main loop and a function pointer table, like kvm does with vmx and svm. -- error compiling committee.c: too many arguments to function