From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 8/9] KVM: Rework of guest debug state writing Date: Sun, 21 Feb 2010 11:26:55 +0200 Message-ID: <4B80FC5F.1020804@redhat.com> References: <68e0d2c45f24b4c183cc1827902afc46d280d89b.1266603744.git.jan.kiszka@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, qemu-devel@nongnu.org, Anthony Liguori , Gleb Natapov To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47081 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754904Ab0BUJ1O (ORCPT ); Sun, 21 Feb 2010 04:27:14 -0500 In-Reply-To: <68e0d2c45f24b4c183cc1827902afc46d280d89b.1266603744.git.jan.kiszka@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/19/2010 08:22 PM, Jan Kiszka wrote: > So far we synchronized any dirty VCPU state back into the kernel before > updating the guest debug state. This was a tribute to a deficite in x86 > kernels before 2.6.33. But as this is an arch-dependent issue, it is > better handle in the x86 part of KVM and remove the writeback point for > generic code. This also avoids overwriting the flushed state later on if > user space decides to change some more registers before resuming the > guest. > Inferring one property of kvm.ko from another is not good, since it creates problems with backports. Better to create a separate KVM_CAP_ for the issue you're testing (and we can retroactively apply it to 2.6.33). -- error compiling committee.c: too many arguments to function