From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: PPC: Allocate vcpu struct using vmalloc Date: Sun, 21 Feb 2010 14:29:00 +0200 Message-ID: <4B81270C.4060303@redhat.com> References: <1266578673-32254-1-git-send-email-agraf@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm list To: Alexander Graf Return-path: In-Reply-To: <1266578673-32254-1-git-send-email-agraf-l3A5Bk7waGM@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On 02/19/2010 01:24 PM, Alexander Graf wrote: > We used to use get_free_pages to allocate our vcpu struct. Unfortunately > that call failed on me several times after my machine had a big enough > uptime, as memory became too fragmented by then. > > Fortunately, we don't need it to be page aligned any more! We can just > vmalloc it and everything's great. > Applied, thanks. We have the same problem in x86 (though never observed it in practice); my plan there is to split the various structure so they take less than a page. -- error compiling committee.c: too many arguments to function