From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch uq/master 1/2] virtio-pci: wake up iothread on VIRTIO_PCI_QUEUE_NOTIFY Date: Mon, 22 Feb 2010 16:20:52 +0200 Message-ID: <4B8292C4.9070802@redhat.com> References: <20100222135906.347393434@amt.cnet> <20100222140209.878250600@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11344 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752872Ab0BVOUz (ORCPT ); Mon, 22 Feb 2010 09:20:55 -0500 In-Reply-To: <20100222140209.878250600@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 02/22/2010 03:59 PM, Marcelo Tosatti wrote: > VIRTIO_PCI_QUEUE_NOTIFY is used to inform availability of new buffers, > so wakeup the iothread to process that information immediately. > > Reported-by: Amit Shah > Signed-off-by: Marcelo Tosatti > > Index: qemu/hw/virtio-pci.c > =================================================================== > --- qemu.orig/hw/virtio-pci.c > +++ qemu/hw/virtio-pci.c > @@ -204,6 +204,7 @@ static void virtio_ioport_write(void *op > break; > case VIRTIO_PCI_QUEUE_NOTIFY: > virtio_queue_notify(vdev, val); > + qemu_notify_event(); > break; > virtio_queue_notify() will call ->handle_output(), which should either do what's needed to be done, or wake up some iothread itself. -- error compiling committee.c: too many arguments to function