From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch uq/master 2/2] kvm-all.c: define smp_wmb and use it for coalesced mmio Date: Mon, 22 Feb 2010 16:23:32 +0200 Message-ID: <4B829364.7020300@redhat.com> References: <20100222135906.347393434@amt.cnet> <20100222140210.130087300@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, "Michael S. Tsirkin" To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7541 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753208Ab0BVOXi (ORCPT ); Mon, 22 Feb 2010 09:23:38 -0500 In-Reply-To: <20100222140210.130087300@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 02/22/2010 03:59 PM, Marcelo Tosatti wrote: > Cc: "Michael S. Tsirkin" > Signed-off-by: Marcelo Tosatti > > Index: qemu/kvm-all.c > =================================================================== > --- qemu.orig/kvm-all.c > +++ qemu/kvm-all.c > @@ -718,6 +718,9 @@ static int kvm_handle_io(uint16_t port, > return 1; > } > > +/* FIXME: arch dependant, x86 version */ > +#define smp_wmb() asm volatile("" ::: "memory") > + > sfence? what about other arches? -- error compiling committee.c: too many arguments to function