From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/6] KVM: SVM: Emulate nRIP feature when reinjecting INT3 Date: Tue, 23 Feb 2010 12:23:11 +0200 Message-ID: <4B83AC8F.2050100@redhat.com> References: <328a33f99bb80c0a9730e323ab69e757b145227e.1266861080.git.jan.kiszka@siemens.com> <20100223101314.GE29041@redhat.com> <4B83AB3C.2090307@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , Marcelo Tosatti , kvm To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54077 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411Ab0BWKXU (ORCPT ); Tue, 23 Feb 2010 05:23:20 -0500 In-Reply-To: <4B83AB3C.2090307@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/23/2010 12:17 PM, Jan Kiszka wrote: >> >> Why have you moved svm_queue_exception() function? >> >> > To avoid adding a prototype. > It's often better to do this in a separate patch: the changelog answers the question above, and the following patch is smaller. -- error compiling committee.c: too many arguments to function