From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 6/6] KVM: x86: Emulator support for TF Date: Tue, 23 Feb 2010 12:29:25 +0200 Message-ID: <4B83AE05.3070505@redhat.com> References: <20100223095553.GC29041@redhat.com> <4B83A9B1.2060103@siemens.com> <20100223102620.GF29041@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , Marcelo Tosatti , kvm To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42954 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332Ab0BWK32 (ORCPT ); Tue, 23 Feb 2010 05:29:28 -0500 In-Reply-To: <20100223102620.GF29041@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/23/2010 12:26 PM, Gleb Natapov wrote: > On Tue, Feb 23, 2010 at 11:10:57AM +0100, Jan Kiszka wrote: > >> Gleb Natapov wrote: >> >>> On Mon, Feb 22, 2010 at 06:51:23PM +0100, Jan Kiszka wrote: >>> >>>> Support both guest- as well as host-owned EFLAGS.TF while emulating >>>> instructions. For guest-owned TF, we simply inject DB and update DR6.BS >>>> after completing an instruction that has TF set on entry. To support >>>> guest single-stepping under host control, we store the pending step >>>> along with its CS and RIP and trigger a corresponding user space exit >>>> once guest execution is about to resume. This check is is also required >>>> in the VMX emulation loop during invalid guest states. >>>> >>>> >>> Emulator currently is a total mess. It is not a good time to add more mess >>> there right now IMO. >>> >> Then let's clean up what you consider "mess" in this feature. Unless >> there are plans to clean up the emulator for the next or next-but-one >> kernel release, I do not want to wait for this. >> >> > There are plans to cleanup the emulator. > That shouldn't stop the code. -- error compiling committee.c: too many arguments to function