From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 6/6] KVM: x86: Emulator support for TF Date: Tue, 23 Feb 2010 12:34:04 +0200 Message-ID: <4B83AF1C.5030100@redhat.com> References: <20100223095553.GC29041@redhat.com> <4B83A9B1.2060103@siemens.com> <20100223102620.GF29041@redhat.com> <4B83AE05.3070505@redhat.com> <20100223103253.GH29041@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Kiszka , Marcelo Tosatti , kvm To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:64820 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750958Ab0BWKjP (ORCPT ); Tue, 23 Feb 2010 05:39:15 -0500 In-Reply-To: <20100223103253.GH29041@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/23/2010 12:32 PM, Gleb Natapov wrote: >>>>> >>>>> Emulator currently is a total mess. It is not a good time to add more mess >>>>> there right now IMO. >>>>> >>>> Then let's clean up what you consider "mess" in this feature. Unless >>>> there are plans to clean up the emulator for the next or next-but-one >>>> kernel release, I do not want to wait for this. >>>> >>>> >>> There are plans to cleanup the emulator. >>> >> That shouldn't stop the code. >> >> > If the code is correct and doesn't make emulator code even messier. > Definitely. I'm sure Jan will address concrete comments. -- error compiling committee.c: too many arguments to function