From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 6/6] KVM: x86: Emulator support for TF Date: Tue, 23 Feb 2010 13:41:44 +0200 Message-ID: <4B83BEF8.5050503@redhat.com> References: <20100223095553.GC29041@redhat.com> <4B83A9B1.2060103@siemens.com> <20100223102620.GF29041@redhat.com> <4B83AFE1.3070905@siemens.com> <20100223110054.GI29041@redhat.com> <4B83BC53.6090102@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , Marcelo Tosatti , kvm To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58687 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751037Ab0BWLlr (ORCPT ); Tue, 23 Feb 2010 06:41:47 -0500 In-Reply-To: <4B83BC53.6090102@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/23/2010 01:30 PM, Jan Kiszka wrote: >> >> How to detect that emulation is complete? emulate_instruction() should >> return EMULATE_DONE in this case. >> > ...*and* RIP moved forward. > A branch or rep instruction can successfully execute and not change rip. Btw, do we expect a #DB on every iteration of rep? In this case we need to modify the code, currently we'll batch rep;ins and rep;outs up to a page's worth. -- error compiling committee.c: too many arguments to function