From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Subject: Re: [PATCH 0/1] KVM: make get dirty log ioctl return the first dirty
 page's position
Date: Wed, 24 Feb 2010 18:45:59 +0900
Message-ID: <4B84F557.6020400@oss.ntt.co.jp>
References: <20100224174303.881da4f4.yoshikawa.takuya@oss.ntt.co.jp> <4B84E985.8000508@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from serv2.oss.ntt.co.jp ([222.151.198.100]:57204 "EHLO
	serv2.oss.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755706Ab0BXJnh (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 24 Feb 2010 04:43:37 -0500
In-Reply-To: <4B84E985.8000508@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Avi Kivity wrote:
>>
>> Result:
>> ...
>> kvm_get_map(slot 0): r=    3, slot.len=    655360(2)
>> kvm_get_map(slot 1): r= 2044, slot.len= 535822336(2044)
>> kvm_get_map(slot 2): r=    1, slot.len=    131072(0)
>> kvm_get_map(slot 3): r=    1, slot.len=    131072(0)
>> kvm_get_map(slot 4): r=    1, slot.len=    131072(0)
>> kvm_get_map(slot 5): r=   64, slot.len=  16777216(64)
>> kvm_get_map(slot 6): r=    1, slot.len=     32768(0)
>> kvm_get_map(slot 7): r=    1, slot.len=     32768(0)
>> kvm_get_map(slot 0): r=    3, slot.len=    655360(2)
>> kvm_get_map(slot 1): r= 2044, slot.len= 535822336(2044)
>> kvm_get_map(slot 2): r=    1, slot.len=    131072(0)
>> kvm_get_map(slot 3): r=    1, slot.len=    131072(0)
>> kvm_get_map(slot 4): r=    1, slot.len=    131072(0)
>> kvm_get_map(slot 5): r=   64, slot.len=  16777216(64)
>> kvm_get_map(slot 6): r=    1, slot.len=     32768(0)
>> kvm_get_map(slot 7): r=    1, slot.len=     32768(0)
>> kvm_get_map(slot 0): r=    3, slot.len=    655360(2)
>> kvm_get_map(slot 1): r= 2044, slot.len= 535822336(2044)
>> kvm_get_map(slot 2): r=    1, slot.len=    131072(0)
>> kvm_get_map(slot 3): r=    1, slot.len=    131072(0)
>> kvm_get_map(slot 4): r=    1, slot.len=    131072(0)
>> kvm_get_map(slot 5): r=   64, slot.len=  16777216(64)
>> kvm_get_map(slot 6): r=    1, slot.len=     32768(0)
>> kvm_get_map(slot 7): r=    1, slot.len=     32768(0)
>> kvm_get_map(slot 0): r=    3, slot.len=    655360(2)
>> kvm_get_map(slot 1): r= 2044, slot.len= 535822336(2044)
>> kvm_get_map(slot 2): r=    1, slot.len=    131072(0)
>> kvm_get_map(slot 3): r=    1, slot.len=    131072(0)
>> kvm_get_map(slot 4): r=    1, slot.len=    131072(0)
>> kvm_get_map(slot 5): r=   64, slot.len=  16777216(64)
>> kvm_get_map(slot 6): r=    1, slot.len=     32768(0)
>> kvm_get_map(slot 7): r=    1, slot.len=     32768(0)
>> ...
>>    
> 
> Seems to confirm - not much can be skipped.
> 


 >> kvm_get_map(slot 1): r= 2044, slot.len= 535822336(2044)
Am I wrong? in this case, the return value is suggesting
we can skip every 2044(the value in the bracket) bitmap check, right?



> 
>