Re: [PATCH] KVM: x86: Kick VCPU outside PIC lock again

Jan Kiszka
2010-02-24T11:42:52Z

Avi Kivity wrote:
> On 02/24/2010 12:28 PM, Jan Kiszka wrote:
>> Jan Kiszka wrote:
>>
>>> Avi Kivity wrote:
>>>
>>>> On 02/24/2010 12:13 PM, Jan Kiszka wrote:
>>>>
>>>>>
>>>>>> I see. Won't we hit the same issue when we call pic functions from
>>>>>> atomic context during the guest entry sequence?
>>>>>>
>>>>>>
>>>>>>
>>>>> If there are such call paths, for sure. What concrete path(s) do you
>>>>> have in mind?
>>>>>
>>>>>
>>>>>
>>>> vcpu_enter_guest() -> inject_pending_event() ->
>>>> kvm_cpu_{has,get}_interrupt() -> various pic functions if you're unlucky.
>>>>
>>> But do they kick anyone or just check/pull information? Never saw any
>>> warnings during my tests last year (granted: with older -rt and kvm
>>> versions).
>>>
>> Mmh, they could if there is> 1 IRQ pending. Guess this just never
>> triggered in real life due to typical APIC use and low IRQ load during
>> PIC times in my tests.
>>
>
> We could just ignore the wakeup in this path. It's called in vcpu
> context, so obviously the vcpu is awake and kicking it will only hurt
> your feet.

Looking at kvm_vcpu_kick, this already happens: The wake queue is
checked for pending waiters (ie. non if waking ourself), and no IPI is
sent if we run on the same CPU like the VCPU is on. That explains why
this path is practically safe.

>
> Longer term, we should clear up this mess. One possible path is to move
> the pic/lapic/injection stuff out of the the critical section, and use
> vcpu->requests to close the race between querying the pic/lapic and
> entering the guest.
>

Sounds worthwhile as well.

Jan

--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux