From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 3/5] KVM: SVM: Use svm_msrpm_offset in nested_svm_exit_handled_msr
Date: Fri, 26 Feb 2010 12:30:40 +0200
Message-ID: <4B87A2D0.2040605@redhat.com>
References: <1267118149-15737-1-git-send-email-joerg.roedel@amd.com> <1267118149-15737-4-git-send-email-joerg.roedel@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Alexander Graf <agraf@suse.de>, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Joerg Roedel <joerg.roedel@amd.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1267118149-15737-4-git-send-email-joerg.roedel@amd.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

On 02/25/2010 07:15 PM, Joerg Roedel wrote:
> There is a generic function now to calculate msrpm offsets.
> Use that function in nested_svm_exit_handled_msr() remove
> the duplicate logic.
>
>    

Hm, if the function would also calculate the mask, then it would be 
useful for set_msr_interception() as well.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.