Re: [ANNOUNCE] kvm-kmod-2.6.33

[Jan Kiszka <jan.kiszka@siemens.com>]

Ingmar Schraub wrote:
> Hello Jan,
> 
> I can compile kvm-kmod-2.6.32.9 under Ubuntu 9.1 64-Bit, but 'make
> install' fails with
> 
> ingmar@nexoc:~/KVM/kvm-kmod-2.6.32.9$ sudo make install
> [sudo] password for ingmar:
> mkdir -p ///usr/local/include/kvm-kmod/asm/
> install -m 644 usr/include/asm-x86/{kvm,kvm_para}.h
> ///usr/local/include/kvm-kmod/asm/
> install: cannot stat `usr/include/asm-x86/{kvm,kvm_para}.h': No such
> file or directory
> make: *** [install-hdr] Error 1
> 
> Before I used kvm-kmod-2.6.32.3 which installs just fine:
> 
> ingmar@nexoc:~/KVM/kvm-kmod-2.6.32.3$ sudo make install
> mkdir -p ///lib/modules/2.6.31-19-generic/extra
> cp x86/*.ko ///lib/modules/2.6.31-19-generic/extra
> for i in ///lib/modules/2.6.31-19-generic/kernel/drivers/kvm/*.ko \
> 		 ///lib/modules/2.6.31-19-generic/kernel/arch/x86/kvm/*.ko; do \
> 		if [ -f "$i" ]; then mv "$i" "$i.orig"; fi; \
> 	done
> /sbin/depmod -a 2.6.31-19-generic -b /
> install -m 644 -D scripts/65-kvm.rules //etc/udev/rules.d/65-kvm.rules
> install -m 644 -D usr/include/asm-x86/kvm.h
> ///usr/local/include/kvm-kmod/asm/kvm.h
> install -m 644 -D usr/include/linux/kvm.h
> ///usr/local/include/kvm-kmod/linux/kvm.h
> sed 's|PREFIX|/usr/local|; s/VERSION/kvm-kmod-2.6.32.3/' kvm-kmod.pc >
> .tmp.kvm-kmod.pc
> install -m 644 -D .tmp.kvm-kmod.pc ///usr/local/lib/pkgconfig/kvm-kmod.pc
> 
> Any idea what could be wrong?
> 

Likely bash'ism of mine (what's your shell?). This should fix it:

diff --git a/Makefile b/Makefile
index 94dde5c..c031701 100644
--- a/Makefile
+++ b/Makefile
@@ -62,9 +62,9 @@ KVM_KMOD_VERSION = $(strip $(if $(wildcard KVM_VERSION), \
 
 install-hdr:
 	mkdir -p $(DESTDIR)/$(HEADERDIR)/asm/
-	install -m 644 usr/include/asm-$(ARCH_DIR)/{kvm,kvm_para}.h $(DESTDIR)/$(HEADERDIR)/asm/
+	install -m 644 usr/include/asm-$(ARCH_DIR)/*.h $(DESTDIR)/$(HEADERDIR)/asm/
 	mkdir -p $(DESTDIR)/$(HEADERDIR)/linux/
-	install -m 644 usr/include/linux/{kvm,kvm_para}.h $(DESTDIR)/$(HEADERDIR)/linux/
+	install -m 644 usr/include/linux/*.h $(DESTDIR)/$(HEADERDIR)/linux/
 	sed 's|PREFIX|$(PREFIX)|; s/VERSION/$(KVM_KMOD_VERSION)/' kvm-kmod.pc > $(tmppc)
 	install -m 644 -D $(tmppc) $(DESTDIR)/$(PKGCONFIGDIR)/kvm-kmod.pc
 

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux