Re: [PATCH 01/15] KVM: PPC: Make register read/write wrappers always work

[Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On 03/05/2010 06:50 PM, Alexander Graf wrote:
> We have wrappers to do for example gpr read/write accesses with,
> because the contents of registers could be either in the PACA
> or in the VCPU struct.
>
> There's nothing that says we have to have the guest vcpu loaded
> when using these wrappers though, so let's introduce a flag that
> tells us whether we're inside a vcpu_load context.
>
>    

On x86 we always access registers within vcpu_load() context.  That 
simplifies things.  Does this not apply here?

Even so, sometimes guest registers are present on the cpu, and sometimes 
in shadow variables (for example, msrs might be loaded or not).  The 
approach here is to always unload and access the variable data.  See for 
example vmx_set_msr() calling vmx_load_host_state() before accessing msrs.

Seems like this could reduce the if () tree?

-- 
error compiling committee.c: too many arguments to function