From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 01/15] KVM: PPC: Make register read/write wrappers always work Date: Mon, 08 Mar 2010 16:23:26 +0200 Message-ID: <4B95085E.5080402@redhat.com> References: <1267807842-3751-1-git-send-email-agraf@suse.de> <1267807842-3751-2-git-send-email-agraf@suse.de> <4B94FE41.1040904@redhat.com> <4B94FF56.9060200@suse.de> <4B9500B2.7030708@redhat.com> <4B950174.7010709@suse.de> <4B950475.1020106@redhat.com> <4B95062D.2020908@suse.de> <4B9506C5.30606@redhat.com> <4B9507C8.6090509@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:7625 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754713Ab0CHOXa (ORCPT ); Mon, 8 Mar 2010 09:23:30 -0500 In-Reply-To: <4B9507C8.6090509@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 03/08/2010 04:20 PM, Alexander Graf wrote: > Avi Kivity wrote: > >> On 03/08/2010 04:14 PM, Alexander Graf wrote: >> >>> We're looking at two different ifs here. >>> >>> 1) GPR Inside the PACA or not (volatile vs non-volatile) >>> >>> This is constant. Volatile registers go to the PACA; non-volatiles go to >>> the vcpu struct. >>> >>> >> Okay - so no if (). >> > Eh. > > r[0 - 12] are volatile > r[13 - 31] are non-volatile > > So if we want a common gpr access function we need an if. And we need > one, because the opcodes just use register numbers and doesn't care > where they are. > I see - we have something similar on x86 (where vmx keeps rsp/rip in a register and lets us save everything else manually). -- error compiling committee.c: too many arguments to function