public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Avi Kivity <avi@redhat.com>
Cc: Bernhard Schmidt <berni@birkenwald.de>, kvm@vger.kernel.org
Subject: Re: linux-aio usable?
Date: Tue, 09 Mar 2010 12:19:11 +0300	[thread overview]
Message-ID: <4B96128F.10608@msgid.tls.msk.ru> (raw)
In-Reply-To: <4B961003.9010807@redhat.com>

Avi Kivity wrote:
> On 03/08/2010 10:19 PM, Michael Tokarev wrote:
>> Michael Tokarev wrote:
>> []
>>   
>>> Apparently that does not quite work.  I just re-compiled kvm with
>>> --enable-linux-aio (actually I just installed libaio-dev on debian
>>> and qemu-kvm's configure picked it up automatically), and tried
>>> a guest.  But any I/O fails.
>>>      
>> It has nothing to do with kvm.  It is compat_ioctl32 in the kernel
>> wrt aio calls.  Historically I've a 64bit kernel with 32bit userland,
>> and tried 32bit kvm too, and that does not work.  But 64bit kvm works
>> just fine with aio, and the performance numbers are indeed better.
> 
> Can you elaborate?  This sounds like a bug that wants to be fixed.

http://thread.gmane.org/gmane.linux.kernel.aio.general/2891

It's missing compat_ioctl for some of the aio opcodes, namely
it's PREADV and PWRITE - the only ones used by kvm and the only
ones missing in kernel.

As far as i can see, current code converts the iocb array just
fine, but does not touch iovec array used with p{read,write}v.

/mjt

  reply	other threads:[~2010-03-09  9:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-08  1:46 linux-aio usable? Bernhard Schmidt
2010-03-08  9:10 ` Avi Kivity
2010-03-08  9:48   ` Bernhard Schmidt
2010-03-08  9:48     ` Avi Kivity
2010-03-08 14:25       ` Dustin Kirkland
2010-03-08 14:26         ` Avi Kivity
2010-03-08 16:28           ` Anthony Liguori
2010-03-08 16:36             ` Avi Kivity
2010-03-08 13:00   ` Christoph Hellwig
2010-03-08 20:11   ` Michael Tokarev
2010-03-08 20:19     ` Michael Tokarev
2010-03-09  9:08       ` Avi Kivity
2010-03-09  9:19         ` Michael Tokarev [this message]
2010-03-09 10:05           ` Avi Kivity
2010-03-09 14:12             ` Christoph Hellwig
2010-03-08 21:27   ` Nikola Ciprich
2010-03-08 21:46     ` Brian Jackson
2010-03-09  9:09     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B96128F.10608@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=avi@redhat.com \
    --cc=berni@birkenwald.de \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox