From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 02/15] KVM: PPC: Allow userspace to unset the IRQ line Date: Tue, 09 Mar 2010 15:05:45 +0200 Message-ID: <4B9647A9.50108@redhat.com> References: <1268071402-27112-1-git-send-email-agraf@suse.de> <1268071402-27112-3-git-send-email-agraf@suse.de> <4B964412.8030708@redhat.com> <954C5195-A8E4-4CA5-8D5E-AA21E2E21C5B@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexander Graf Return-path: In-Reply-To: <954C5195-A8E4-4CA5-8D5E-AA21E2E21C5B-l3A5Bk7waGM@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On 03/09/2010 02:54 PM, Alexander Graf wrote: > On 09.03.2010, at 13:50, Avi Kivity wrote: > > >> On 03/08/2010 08:03 PM, Alexander Graf wrote: >> >>> Userspace can tell us that it wants to trigger an interrupt. But >>> so far it can't tell us that it wants to stop triggering one. >>> >>> So let's interpret the parameter to the ioctl that we have anyways >>> to tell us if we want to raise or lower the interrupt line. >>> >>> >> I asked for a KVM_CAP_ for this. What was the conclusion of that thread? >> > Uh - did we come to one? > > The last thing you said about it was: > > >> Having individual capabilities makes backporting a lot easier (otherwise you have to backport the whole thing). If the changes are logically separate, I prefer 500 separate capabilities. >> >> However, for a platform bringup, it's okay to have just one capability, assuming none of the changes are applicable to other platforms. >> > So I assumed it'd be ok to not have one. If you like I can send an additional patch adding the CAP. > > Well, what's the capability for this patchset? Things like "if you have KVM_CAP_OSI you can assume you have KVM_INTERRUPT_LOWER" don't work for me. A platform cap would be called KVM_CAP_MOL and explicitly document everything in there. And it commits you to not deprecating things individually. Really, individual caps are better. -- error compiling committee.c: too many arguments to function