From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 09/10] Initialize in-kernel irqchip Date: Tue, 09 Mar 2010 15:21:31 +0200 Message-ID: <4B964B5B.3030801@redhat.com> References: <1267215141-13629-2-git-send-email-glommer@redhat.com> <1267215141-13629-3-git-send-email-glommer@redhat.com> <1267215141-13629-4-git-send-email-glommer@redhat.com> <1267215141-13629-5-git-send-email-glommer@redhat.com> <1267215141-13629-6-git-send-email-glommer@redhat.com> <1267215141-13629-7-git-send-email-glommer@redhat.com> <1267215141-13629-8-git-send-email-glommer@redhat.com> <1267215141-13629-9-git-send-email-glommer@redhat.com> <1267215141-13629-10-git-send-email-glommer@redhat.com> <20100302043135.GC11510@amt.cnet> <20100302182511.GB665@mothafucka.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Glauber Costa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55026 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752477Ab0CINVd (ORCPT ); Tue, 9 Mar 2010 08:21:33 -0500 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o29DLWEZ029831 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Mar 2010 08:21:32 -0500 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o29DLVUF013999 for ; Tue, 9 Mar 2010 08:21:32 -0500 In-Reply-To: <20100302182511.GB665@mothafucka.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 03/02/2010 08:25 PM, Glauber Costa wrote: > On Tue, Mar 02, 2010 at 01:31:35AM -0300, Marcelo Tosatti wrote: > >> On Fri, Feb 26, 2010 at 05:12:20PM -0300, Glauber Costa wrote: >> >>> Now that we have all devices set up, this patch initializes the irqchip. >>> This is dependant on the io-thread, since we need someone to pull ourselves >>> out of the halted state. >>> >> I don't understand why - it should work without iothread. >> > with irqchip in kernel, we have to handle halted state in the kernel too. > We still exit on signals, same as tcg w/o iothread. qemu-kvm had irqchip before iothread, IIRC. -- error compiling committee.c: too many arguments to function