From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 05/10] Don't call apic functions directly from kvm code Date: Tue, 09 Mar 2010 15:27:02 +0200 Message-ID: <4B964CA6.9050909@redhat.com> References: <1267215141-13629-1-git-send-email-glommer@redhat.com> <1267215141-13629-2-git-send-email-glommer@redhat.com> <1267215141-13629-3-git-send-email-glommer@redhat.com> <1267215141-13629-4-git-send-email-glommer@redhat.com> <1267215141-13629-5-git-send-email-glommer@redhat.com> <1267215141-13629-6-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mtosatti@redhat.com To: Glauber Costa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:5551 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900Ab0CIN1E (ORCPT ); Tue, 9 Mar 2010 08:27:04 -0500 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o29DR3Pn014082 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Mar 2010 08:27:04 -0500 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o29DR3x9003245 for ; Tue, 9 Mar 2010 08:27:03 -0500 In-Reply-To: <1267215141-13629-6-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/26/2010 10:12 PM, Glauber Costa wrote: > It is actually not necessary to call a tpr function to save and load cr8, > as cr8 is part of the processor state, and thus, it is much easier > to just add it to CPUState. > > As for apic base, wrap kvm usages, so we can call either the qemu device, > or the in kernel version. > > > } > > +static void kvm_set_apic_base(CPUState *env, uint64_t val) > +{ > + if (!kvm_irqchip_in_kernel()) > + cpu_set_apic_base(env, val); > What if it is in kernel? Just ignored? Doesn't seem right. -- error compiling committee.c: too many arguments to function