From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 22/24] KVM: x86 emulator: restart string instruction without going back to a guest. Date: Wed, 10 Mar 2010 11:14:31 +0200 Message-ID: <4B9762F7.6040506@redhat.com> References: <1268143762-4000-1-git-send-email-gleb@redhat.com> <1268143762-4000-23-git-send-email-gleb@redhat.com> <4B966035.2050904@redhat.com> <20100309181157.GF9066@redhat.com> <4B97043C.2000603@oss.ntt.co.jp> <20100310090633.GS16909@redhat.com> <4B976282.7020108@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , kvm@vger.kernel.org To: Takuya Yoshikawa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19356 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142Ab0CJJOe (ORCPT ); Wed, 10 Mar 2010 04:14:34 -0500 In-Reply-To: <4B976282.7020108@oss.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On 03/10/2010 11:12 AM, Takuya Yoshikawa wrote: >> Entering guest from time to time will not change semantics of the >> processor (if code is not modified under processor's feet at least). >> Currently we reenter guest mode after each iteration of string >> instruction for all instruction but ins/outs. >> > > > E.g., is there no chance that during the repetitions, in the middle of > the > repetitions, page faults occur? If it can, without entering the guest, > can > we handle it? Page faults can occur, and we need to handle them. Another reason for reentering the guest is so that we can inject guest interrupts. -- error compiling committee.c: too many arguments to function