From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 1/3] target-i386: print EFER in cpu_dump_state Date: Thu, 11 Mar 2010 10:35:21 +0200 Message-ID: <4B98AB49.4030209@redhat.com> References: <20100309015343.901738854@redhat.com> <20100309015644.133975091@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38573 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756168Ab0CKIfX (ORCPT ); Thu, 11 Mar 2010 03:35:23 -0500 In-Reply-To: <20100309015644.133975091@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/09/2010 03:53 AM, Marcelo Tosatti wrote: > Signed-off-by: Marcelo Tosatti > > Index: qemu-kvm-uq/target-i386/helper.c > =================================================================== > --- qemu-kvm-uq.orig/target-i386/helper.c > +++ qemu-kvm-uq/target-i386/helper.c > @@ -1176,6 +1176,7 @@ void cpu_dump_state(CPUState *env, FILE > cpu_x86_dump_seg_cache(env, f, cpu_fprintf, "TR",&env->tr); > > #ifdef TARGET_X86_64 > + cpu_fprintf(f, "EFER= %016" PRIx64 "\n", env->efer); > if (env->hflags& HF_LMA_MASK) { > cpu_fprintf(f, "GDT= %016" PRIx64 " %08x\n", > env->gdt.base, env->gdt.limit); > > Better to do this for i386 too, no? -- error compiling committee.c: too many arguments to function