From: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: Move kvm_exit tracepoint rip reading inside tracepoint
Date: Thu, 11 Mar 2010 20:03:11 +0900 [thread overview]
Message-ID: <4B98CDEF.4010003@oss.ntt.co.jp> (raw)
In-Reply-To: <1268297527-9014-1-git-send-email-avi@redhat.com>
Avi Kivity wrote:
> diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h
> index b75efef..3cf9547 100644
> --- a/arch/x86/kvm/trace.h
> +++ b/arch/x86/kvm/trace.h
> @@ -182,8 +182,8 @@ TRACE_EVENT(kvm_apic,
> * Tracepoint for kvm guest exit:
> */
> TRACE_EVENT(kvm_exit,
> - TP_PROTO(unsigned int exit_reason, unsigned long guest_rip),
> - TP_ARGS(exit_reason, guest_rip),
> + TP_PROTO(unsigned int exit_reason, struct kvm_vcpu *vcpu),
Whitespaces were inserted by accident?
> + TP_ARGS(exit_reason, vcpu),
>
> TP_STRUCT__entry(
> __field( unsigned int, exit_reason )
> @@ -192,7 +192,7 @@ TRACE_EVENT(kvm_exit,
>
> TP_fast_assign(
> __entry->exit_reason = exit_reason;
> - __entry->guest_rip = guest_rip;
> + __entry->guest_rip = kvm_rip_read(vcpu);
> ),
>
> TP_printk("reason %s rip 0x%lx",
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index ae3217d..06108f3 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -3605,7 +3605,7 @@ static int vmx_handle_exit(struct kvm_vcpu *vcpu)
> u32 exit_reason = vmx->exit_reason;
> u32 vectoring_info = vmx->idt_vectoring_info;
>
> - trace_kvm_exit(exit_reason, kvm_rip_read(vcpu));
> + trace_kvm_exit(exit_reason, vcpu);
>
> /* If guest state is invalid, start emulating */
> if (vmx->emulation_required && emulate_invalid_guest_state)
next prev parent reply other threads:[~2010-03-11 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 8:52 [PATCH] KVM: Move kvm_exit tracepoint rip reading inside tracepoint Avi Kivity
2010-03-11 11:03 ` Takuya Yoshikawa [this message]
2010-03-11 11:03 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B98CDEF.4010003@oss.ntt.co.jp \
--to=yoshikawa.takuya@oss.ntt.co.jp \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox