public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Dor Laor <dlaor@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Sheng Yang <sheng@linux.intel.com>,
	kvm@vger.kernel.org
Subject: Re: Make QEmu HPET disabled by default for KVM?
Date: Sun, 14 Mar 2010 12:23:25 +0200	[thread overview]
Message-ID: <4B9CB91D.3050708@redhat.com> (raw)
In-Reply-To: <20100314071038.GC19233@redhat.com>

On 03/14/2010 09:10 AM, Gleb Natapov wrote:
> On Sun, Mar 14, 2010 at 09:05:50AM +0200, Avi Kivity wrote:
>> On 03/11/2010 09:08 PM, Marcelo Tosatti wrote:
>>>
>>>>
>>>>> I have kept --no-hpet in my setup for
>>>>> months...
>>>> Any details about the problems?  HPET is important to some guests.
>>> As Gleb mentioned in the other thread, reinjection will introduce
>>> another set of problems.
>>>
>>> Ideally all this timer related problems should be fixed by correlating
>>> timer interrupts and time source reads.
>>
>> This still needs reinjection (or slewing of the timer frequency).
>> Correlation doesn't fix drift.
>>
> But only when all time sources are synchronised and correlated with
> interrupts we can slew time frequency without guest noticing (and only
> if guest disables NTP)

In the mean time we should definitely disable hpet by default.
Besides this we need to fully virtualize the tsc, fix win7 64bit rtc 
time drift and some pvclock potential issues. Before we add new timer, 
better fix existing ones.

What about creating a pv time keeping device that will be aware of lost 
ticks and host wall clock time? It's similar to hyper-v enlightenment 
virt timers.

>
>>> Since one already has to use special timer parameters (-rtc-td-hack,
>>> -no-kvm-pit-reinjection), using -no-hpet for problematic Linux
>>> guests seems fine?
>>
>> Depends on how common the problematic ones are.  If they're common,
>> better to have a generic fix.
>>
>> --
>> error compiling committee.c: too many arguments to function
>
> --
> 			Gleb.
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


  reply	other threads:[~2010-03-14 10:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-11  7:52 Make QEmu HPET disabled by default for KVM? Sheng Yang
2010-03-11  7:58 ` Avi Kivity
2010-03-11  8:23   ` Sheng Yang
2010-03-11  8:28     ` Avi Kivity
2010-03-11  8:31       ` Gleb Natapov
2010-03-11  8:36         ` Avi Kivity
2010-03-11  8:38         ` Sheng Yang
2010-03-11  8:42           ` Gleb Natapov
2010-03-11  8:46             ` Avi Kivity
2010-03-11 10:23               ` Gleb Natapov
2010-03-11 11:56                 ` Avi Kivity
2010-03-11 11:56                   ` Avi Kivity
2010-03-11 19:08   ` Marcelo Tosatti
2010-03-14  7:05     ` Avi Kivity
2010-03-14  7:10       ` Gleb Natapov
2010-03-14 10:23         ` Dor Laor [this message]
2010-03-14 10:27           ` Avi Kivity
2010-03-14 12:51             ` Dor Laor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B9CB91D.3050708@redhat.com \
    --to=dlaor@redhat.com \
    --cc=avi@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=sheng@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox