From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 15/18] KVM: MMU: Propagate the right fault back to the guest after gva_to_gpa Date: Mon, 15 Mar 2010 09:36:52 +0200 Message-ID: <4B9DE394.2080401@redhat.com> References: <1267643541-451-1-git-send-email-joerg.roedel@amd.com> <1267643541-451-16-git-send-email-joerg.roedel@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Alexander Graf , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Joerg Roedel Return-path: In-Reply-To: <1267643541-451-16-git-send-email-joerg.roedel@amd.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 03/03/2010 09:12 PM, Joerg Roedel wrote: > This patch implements logic to make sure that either a > page-fault/page-fault-vmexit or a nested-page-fault-vmexit > is propagated back to the guest. > > Signed-off-by: Joerg Roedel > --- > arch/x86/kvm/mmu.h | 1 + > arch/x86/kvm/paging_tmpl.h | 2 ++ > arch/x86/kvm/x86.c | 15 ++++++++++++++- > 3 files changed, 17 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/kvm/mmu.h b/arch/x86/kvm/mmu.h > index 64f619b..b42b27e 100644 > --- a/arch/x86/kvm/mmu.h > +++ b/arch/x86/kvm/mmu.h > @@ -47,6 +47,7 @@ > #define PFERR_USER_MASK (1U<< 2) > #define PFERR_RSVD_MASK (1U<< 3) > #define PFERR_FETCH_MASK (1U<< 4) > +#define PFERR_NESTED_MASK (1U<< 31) > Why is this needed? Queue an ordinary page fault page; the injection code should check the page fault intercept and #VMEXIT if needed. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.