public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
To: Avi Kivity <avi@redhat.com>
Cc: "Marcelo Tosatti" <mtosatti@redhat.com>,
	kvm@vger.kernel.org,
	"Fernando Luis Vázquez Cao" <fernando@oss.ntt.co.jp>
Subject: Re: [RFC] Moving dirty bitmaps to userspace - Double buffering approach
Date: Mon, 15 Mar 2010 19:50:44 +0900	[thread overview]
Message-ID: <4B9E1104.5010209@oss.ntt.co.jp> (raw)
In-Reply-To: <4B9DF491.5010805@redhat.com>

Avi Kivity wrote:
> On 03/15/2010 10:33 AM, Marcelo Tosatti wrote:
>>
>>> Are there any good ways to solve this kind of problems?
>>>      
>> You can introduce a new get_dirty_log ioctl that passes the address
>> of the next bitmap in userspace, and use it (after pinning with
>> get_user_pages), instead of vmalloc'ing.
>>

Thank you for your advice!

>>    
> 
> No pinning please, put_user_bit() or set_bit_user().
> 
> (can be implemented generically using get_user_pages() and 
> kmap_atomic(), but x86 should get an optimized implementation)
> 

Given your advice last time, I started this with my colleague.
  -- We were just talking about how to strugle with every architectures.

As your comment, we'll make the generic implementation with optimized one
for x86 first.

Thanks
   Takuya

      reply	other threads:[~2010-03-15 10:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-08  8:22 [RFC] Moving dirty bitmaps to userspace - Double buffering approach Takuya Yoshikawa
2010-03-08 12:57 ` Avi Kivity
2010-03-15  8:33 ` Marcelo Tosatti
2010-03-15  8:49   ` Avi Kivity
2010-03-15 10:50     ` Takuya Yoshikawa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B9E1104.5010209@oss.ntt.co.jp \
    --to=yoshikawa.takuya@oss.ntt.co.jp \
    --cc=avi@redhat.com \
    --cc=fernando@oss.ntt.co.jp \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox