From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 06/30] KVM: remove realmode_lmsw function. Date: Mon, 15 Mar 2010 13:41:25 +0200 Message-ID: <4B9E1CE5.5050003@redhat.com> References: <1268583675-3101-1-git-send-email-gleb@redhat.com> <1268583675-3101-7-git-send-email-gleb@redhat.com> <4B9E13DC.8000607@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , mtosatti@redhat.com, kvm@vger.kernel.org To: Andre Przywara Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59660 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755981Ab0COLl2 (ORCPT ); Mon, 15 Mar 2010 07:41:28 -0400 In-Reply-To: <4B9E13DC.8000607@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/15/2010 01:02 PM, Andre Przywara wrote: > Gleb Natapov wrote: >> Use (get|set)_cr callback to emulate lmsw inside emulator. > I see that vmx.c:handle_cr() is the only other user of kvm_lmsw(). If > we fix this place similar like you did below, we could get rid of > kvm_lmsw() entirely. But I am not sure whether it's OK to remove an > exported symbol. Exported symbols can be changed or removed at will. -- error compiling committee.c: too many arguments to function