From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 0/5] Fix some mmu/emulator atomicity issues (v2)
Date: Mon, 15 Mar 2010 13:52:51 +0200 [thread overview]
Message-ID: <4B9E1F93.3010905@redhat.com> (raw)
In-Reply-To: <20100315101639.GA31813@amt.cnet>
On 03/15/2010 12:16 PM, Marcelo Tosatti wrote:
> On Sun, Mar 14, 2010 at 09:03:47AM +0200, Avi Kivity wrote:
>
>> On 03/10/2010 04:50 PM, Avi Kivity wrote:
>>
>>> Currently when we emulate a locked operation into a shadowed guest page
>>> table, we perform a write rather than a true atomic. This is indicated
>>> by the "emulating exchange as write" message that shows up in dmesg.
>>>
>>> In addition, the pte prefetch operation during invlpg suffered from a
>>> race. This was fixed by removing the operation.
>>>
>>> This patchset fixes both issues and reinstates pte prefetch on invlpg.
>>>
>>> v2:
>>> - fix truncated description for patch 1
>>> - add new patch 4, which fixes a bug in patch 5
>>>
>> No comments, but looks like last week's maintainer neglected to merge this.
>>
> Looks fine. Can you please regenerate against next branch? (just
> pushed).
>
Will send out shortly.
> For the invlpg prefetch it would be good to confirm the original bug is
> not reproducible.
>
I tried to reproduce the problem with the original revert reverted, but
couldn't.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-03-15 11:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 14:50 [PATCH 0/5] Fix some mmu/emulator atomicity issues (v2) Avi Kivity
2010-03-10 14:50 ` [PATCH 1/5] KVM: MMU: Consolidate two guest pte reads in kvm_mmu_pte_write() Avi Kivity
2010-03-10 14:50 ` [PATCH 2/5] KVM: Make locked operations truly atomic Avi Kivity
2010-03-10 14:50 ` [PATCH 3/5] KVM: Don't follow an atomic operation by a non-atomic one Avi Kivity
2010-03-10 14:50 ` [PATCH 4/5] KVM: MMU: Do not instantiate nontrapping spte on unsync page Avi Kivity
2010-03-10 14:50 ` [PATCH 5/5] KVM: MMU: Reinstate pte prefetch on invlpg Avi Kivity
2010-03-14 7:03 ` [PATCH 0/5] Fix some mmu/emulator atomicity issues (v2) Avi Kivity
2010-03-15 10:16 ` Marcelo Tosatti
2010-03-15 11:52 ` Avi Kivity [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-03-15 11:59 Avi Kivity
2010-03-16 16:36 ` Marcelo Tosatti
2010-03-16 18:22 ` Alexander Graf
2010-03-16 19:33 ` Marcelo Tosatti
2010-03-17 3:58 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9E1F93.3010905@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox