From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/5] Fix some mmu/emulator atomicity issues (v2) Date: Mon, 15 Mar 2010 13:52:51 +0200 Message-ID: <4B9E1F93.3010905@redhat.com> References: <1268232631-1579-1-git-send-email-avi@redhat.com> <4B9C8A53.8030902@redhat.com> <20100315101639.GA31813@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63916 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936150Ab0COLww (ORCPT ); Mon, 15 Mar 2010 07:52:52 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2FBqqHg007561 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Mar 2010 07:52:52 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o2FBqpDC026058 for ; Mon, 15 Mar 2010 07:52:52 -0400 In-Reply-To: <20100315101639.GA31813@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 03/15/2010 12:16 PM, Marcelo Tosatti wrote: > On Sun, Mar 14, 2010 at 09:03:47AM +0200, Avi Kivity wrote: > >> On 03/10/2010 04:50 PM, Avi Kivity wrote: >> >>> Currently when we emulate a locked operation into a shadowed guest page >>> table, we perform a write rather than a true atomic. This is indicated >>> by the "emulating exchange as write" message that shows up in dmesg. >>> >>> In addition, the pte prefetch operation during invlpg suffered from a >>> race. This was fixed by removing the operation. >>> >>> This patchset fixes both issues and reinstates pte prefetch on invlpg. >>> >>> v2: >>> - fix truncated description for patch 1 >>> - add new patch 4, which fixes a bug in patch 5 >>> >> No comments, but looks like last week's maintainer neglected to merge this. >> > Looks fine. Can you please regenerate against next branch? (just > pushed). > Will send out shortly. > For the invlpg prefetch it would be good to confirm the original bug is > not reproducible. > I tried to reproduce the problem with the original revert reverted, but couldn't. -- error compiling committee.c: too many arguments to function