From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 05/30] KVM: Provide callback to get/set control registers in emulator ops. Date: Mon, 15 Mar 2010 15:13:09 +0200 Message-ID: <4B9E3265.4060908@redhat.com> References: <1268583675-3101-1-git-send-email-gleb@redhat.com> <1268583675-3101-6-git-send-email-gleb@redhat.com> <4B9E30E8.5000506@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , mtosatti@redhat.com, kvm@vger.kernel.org To: Andre Przywara Return-path: Received: from mx1.redhat.com ([209.132.183.28]:5800 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964844Ab0CONNN (ORCPT ); Mon, 15 Mar 2010 09:13:13 -0400 In-Reply-To: <4B9E30E8.5000506@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/15/2010 03:06 PM, Andre Przywara wrote: > Gleb Natapov wrote: >> Use this callback instead of directly call kvm function. Also rename >> realmode_(set|get)_cr to emulator_(set|get)_cr since function has >> nothing >> to do with real mode. > Do you mind removing the static before emulator_{set,get}_cr and > marking it EXPORT_SYMBOL? Then one could use it in vmx.c (and soon in > svm.c ;-) while handling MOV-CR intercepts. Currently most of the code > is actually duplicated. Just do that in your patch, that's standard practice. -- error compiling committee.c: too many arguments to function