From: Avi Kivity <avi@redhat.com>
To: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org,
anthony@codemonkey.ws, ohmura.kei@lab.ntt.co.jp
Subject: Re: [PATCH 1/6] qemu-kvm: Introduce bit-based phys_ram_dirty for VGA, CODE and MIGRATION.
Date: Tue, 16 Mar 2010 15:04:09 +0200 [thread overview]
Message-ID: <4B9F81C9.7020308@redhat.com> (raw)
In-Reply-To: <4B9F8119.5040404@lab.ntt.co.jp>
On 03/16/2010 03:01 PM, Yoshiaki Tamura wrote:
>>> -uint8_t *phys_ram_dirty;
>>> +unsigned long *phys_ram_vga_dirty;
>>> +unsigned long *phys_ram_code_dirty;
>>> +unsigned long *phys_ram_migration_dirty;
>>
>> Would be nice to make this an array.
>
>
> Thanks for pointing out.
> I have a question regarding the index of the array.
> From the compatibility perspective, I would prefer using the existing
> macros.
>
> #define VGA_DIRTY_FLAG 0x01
> #define CODE_DIRTY_FLAG 0x02
> #define MIGRATION_DIRTY_FLAG 0x08
>
> However, if I use them as is, I'll get a sparse array...
> Is it acceptable to change these values like 0, 1, 2?
Sure.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-03-16 13:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 10:53 [PATCH 0/6] qemu-kvm: Introduce bit-based phys_ram_dirty, and bit-based dirty page checker Yoshiaki Tamura
2010-03-16 10:53 ` [PATCH 1/6] qemu-kvm: Introduce bit-based phys_ram_dirty for VGA, CODE and MIGRATION Yoshiaki Tamura
2010-03-16 12:26 ` Avi Kivity
2010-03-16 13:01 ` Yoshiaki Tamura
2010-03-16 13:04 ` Avi Kivity [this message]
2010-03-16 10:53 ` [PATCH 2/6] qemu-kvm: Modify and introduce wrapper functions to access phys_ram_dirty Yoshiaki Tamura
2010-03-16 12:45 ` Avi Kivity
2010-03-16 13:17 ` Yoshiaki Tamura
2010-03-16 13:29 ` Avi Kivity
2010-03-16 13:49 ` Yoshiaki Tamura
2010-03-16 13:51 ` Anthony Liguori
2010-03-16 13:57 ` Avi Kivity
2010-03-16 14:50 ` Anthony Liguori
2010-03-16 20:10 ` [Qemu-devel] " Blue Swirl
2010-03-16 22:31 ` Richard Henderson
2010-03-17 0:05 ` [Qemu-devel] " Paul Brook
2010-03-17 4:07 ` Avi Kivity
2010-03-17 16:06 ` Paul Brook
2010-03-17 16:28 ` Avi Kivity
2010-03-16 13:35 ` Anthony Liguori
2010-03-16 22:50 ` Yoshiaki Tamura
2010-03-16 10:53 ` [PATCH 3/6] qemu-kvm: Replace direct phys_ram_dirty access with wrapper functions Yoshiaki Tamura
2010-03-16 10:53 ` [PATCH 4/6] qemu-kvm: Introduce cpu_physical_memory_get_dirty_range() Yoshiaki Tamura
2010-03-16 12:47 ` Avi Kivity
2010-03-16 10:53 ` [PATCH 5/6] qemu-kvm: Use cpu_physical_memory_set_dirty_range() to update phys_ram_dirty Yoshiaki Tamura
2010-03-16 10:53 ` [PATCH 6/6] qemu-kvm: Use cpu_physical_memory_get_dirty_range() to check multiple dirty pages Yoshiaki Tamura
2010-03-16 13:11 ` [PATCH 0/6] qemu-kvm: Introduce bit-based phys_ram_dirty, and bit-based dirty page checker Avi Kivity
2010-03-16 13:41 ` Yoshiaki Tamura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9F81C9.7020308@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=ohmura.kei@lab.ntt.co.jp \
--cc=qemu-devel@nongnu.org \
--cc=tamura.yoshiaki@lab.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox