From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/5] Fix some mmu/emulator atomicity issues (v2) Date: Wed, 17 Mar 2010 05:58:45 +0200 Message-ID: <4BA05375.4030204@redhat.com> References: <1268654397-6650-1-git-send-email-avi@redhat.com> <20100316163649.GA9718@amt.cnet> <17398A15-DD8E-469C-BFFA-97AECADB3328@suse.de> <20100316193329.GA13101@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Graf , kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51913 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396Ab0CQD6u (ORCPT ); Tue, 16 Mar 2010 23:58:50 -0400 In-Reply-To: <20100316193329.GA13101@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 03/16/2010 09:33 PM, Marcelo Tosatti wrote: > >> How relevant is this for -stable? Races don't sound good to me :) >> > The race mentioned above is not existant on -stable since prefetch is > disabled for invlpg. > > The atomic fixes seem like a candidate, since lack of them can trigger > pagetable corruption. Avi? > I would this to get some use on mainline before queuing the first few patches. They aren't trivial, and I don't know of any failures resulting from the races. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.