From mboxrd@z Thu Jan  1 00:00:00 1970
From: OHMURA Kei <ohmura.kei@lab.ntt.co.jp>
Subject: Re: virtio_blk_load() question
Date: Fri, 19 Mar 2010 11:53:48 +0900
Message-ID: <4BA2E73C.1080405@lab.ntt.co.jp>
References: <4BA1AC4A.2070402@lab.ntt.co.jp> <m3hboenkr0.fsf@trasno.mitica>	<4BA1F578.4040500@lab.ntt.co.jp> <m3eijhomsy.fsf@trasno.mitica>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Avi Kivity <avi@redhat.com>,
	Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>,
	ohmura.kei@lab.ntt.co.jp
To: Juan Quintela <quintela@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from tama500.ecl.ntt.co.jp ([129.60.39.148]:58864 "EHLO
	tama500.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751951Ab0CSCyH (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 18 Mar 2010 22:54:07 -0400
In-Reply-To: <m3eijhomsy.fsf@trasno.mitica>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 2010/03/18 21:07, Juan Quintela wrote:
> Really, ordering doesn't matter (in this case):
> 
> see virtio-blk.c:virtio_blk_dma_restart_bh()
> 
>     QLIST_FOREACH_SAFE(req, &rq_copy, next, next_req) {
>         QLIST_REMOVE(req, next);
>         virtio_blk_handle_request(req, &mrb);
>     }
> 
> This mean that we are just removing from the beggining and addin from
> the beginnig (i.e. reversing).  Adding by the beggining made it easier,
> but I can change if you mean.

Thanks, I understood.
However, since it's difficult to understand this at first glance,
it would be great if you could modify, but I'm OK if you could just add
comments on this to the exiting patch.  It's kind for a newbie like me.


> Notice that except if there are any errors (I was not able to trigger
> it, but didnt' try too hard), that list is going to be syncked in the 
> 
>         qemu_aio_flush();
>         bdrv_flush_all();
> 
> in migrate_fd_put_ready(), so it is not trivial to hit it and probably
> the difference is just theoretical.

Thank you for your information.