Re: [PATCH] Enhance perf to collect KVM guest os statistics from host side

oerg Roedel
2010-03-19T17:29:03Z

On Fri, Mar 19, 2010 at 09:21:22AM +0100, Ingo Molnar wrote:
> Unfortunately, in a previous thread the Qemu maintainer has indicated that he
> will essentially NAK any attempt to enhance Qemu to provide an easily
> discoverable, self-contained, transparent guest mount on the host side.
>
> No technical justification was given for that NAK, despite my repeated
> requests to particulate the exact security problems that such an approach
> would cause.
>
> If that NAK does not stand in that form then i'd like to know about it - it
> makes no sense for us to try to code up a solution against a standing
> maintainer NAK ...

I still think it is the best and most generic way to let the guest do
the symbol resolution. This has several advantages:

1. The guest knows best about its symbol space. So this would be
extensible to other guest operating systems. A brave
developer may even implement symbol passing for Windows or
the BSDs ;-)

2. The guest can decide for its own if it want to pass this
inforamtion to the host-perf. No security issues at all.

3. The guest can also pass us the call-chain and we don't need
to care about complicated of fetching from the guest
ourself.

4. This way extensible to nested virtualization too.

How we speak to the guest was already discussed in this thread. My
personal opinion is that going through qemu is an unnecessary step and
we can solve that more clever and transparent for perf.

Joerg