From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Subject: Re: Updating dirty bitmap by non-atomic set bit is safe?
Date: Tue, 23 Mar 2010 19:17:03 +0900
Message-ID: <4BA8951F.7060109@oss.ntt.co.jp>
References: <4BA85BB4.8030001@oss.ntt.co.jp> <4BA8875D.3000506@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-2022-JP
Content-Transfer-Encoding: 7bit
Cc: KVM list <kvm@vger.kernel.org>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from serv2.oss.ntt.co.jp ([222.151.198.100]:44593 "EHLO
	serv2.oss.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751336Ab0CWKOS (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 23 Mar 2010 06:14:18 -0400
In-Reply-To: <4BA8875D.3000506@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Avi Kivity wrote:
> On 03/23/2010 08:12 AM, Takuya Yoshikawa wrote:
>> Hi, does anybody knows about this?
>>
>>
>> Currently, dirty bitmap is updated by generic___set_le_bit().
>> I checked the git log and mail archives but could not find any
>> explanation why replacing set_bit() by generic___set_le_bit() is
>> safe.
>>   
> 
> IIRC it's protected by the mmu spinlock.
> 

So the fact is the old version did extra protection, thank you.