Re: [PATCH] Enhance perf to collect KVM guest os statistics from host side

Ingo Molnar
2010-03-22T12:26:04Z

* Joerg Roedel <joro@8bytes.org> wrote:

> On Mon, Mar 22, 2010 at 11:59:27AM +0100, Ingo Molnar wrote:
> > Best would be if you demonstrated any problems of the perf symbol lookup code
> > you are aware of on the host side, as it has that exact design you are
> > criticising here. We are eager to fix any bugs in it.
> >
> > If you claim that it's buggy then that should very much be demonstratable - no
> > need to go into theoretical arguments about it.
>
> I am not claiming anything. I just try to imagine how your proposal will
> look like in practice and forgot that symbol resolution is done at a later
> point.
>
> But even with defered symbol resolution we need more information from the
> guest than just the rip falling out of KVM. The guest needs to tell us about
> the process where the event happened (information that the host has about
> itself without any hassle) and which executable-files it was loaded from.

Correct - for full information we need a good paravirt perf integration of the
kernel bits to pass that through. (I.e. we want to 'integrate' the PID space
as well, at least within the perf notion of PIDs.)

Initially we can do without that as well.

> Probably. At least it is the solution that fits best into the current design
> of perf. But we should think about how this will be done. Raw disk access is
> no solution because we need to access virtual file-systems of the guest too.
> [...]

I never said anything about 'raw disk access'. Have you seen my proposal of
(optional) VFS namespace integration? (It can be found repeated the Nth time
in my mail you replied to)

Thanks,

Ingo