From: Jason Wang <jasowang@redhat.com>
To: Lucas Meneghel Rodrigues <lmr@redhat.com>
Cc: Martin Bligh <mbligh@google.com>,
autotest@test.kernel.org, Michael Davidson <md@google.com>,
kvm@vger.kernel.org
Subject: Re: [Autotest] [PATCH] Monotonic time test: Don't force static compilation of time_test
Date: Wed, 24 Mar 2010 09:16:30 +0800 [thread overview]
Message-ID: <4BA967EE.1080900@redhat.com> (raw)
In-Reply-To: <6ac58f4f1003231356v7abdeb93v2810e56cb3877749@mail.gmail.com>
Lucas Meneghel Rodrigues wrote:
> On Tue, Mar 23, 2010 at 3:25 PM, Martin Bligh <mbligh@google.com> wrote:
>
>> +cc:md (he wrote the test).
>>
>> On Tue, Mar 23, 2010 at 11:13 AM, Lucas Meneghel Rodrigues
>> <lmr@redhat.com> wrote:
>>
>>> The Makefile for the monotonic_test C program forces static
>>> compilation of the object files. Since we are compiling the
>>> code already, not having a static binary doesn't make much
>>> of a difference on the systems we are running this test.
>>>
>>> As the static compilation might fail in some boxes, just remove
>>> this constraint from the Makefile.
>>>
>> I presume this was to fix some Google interdependency.
>> Is it actually breaking something? If not, seems safer to leave it?
>> If so, we'll have to fix one end or the other ;-)
>>
>
> Yes, I can't get a static build on a Fedora 13 box by no means, that's
> why I looked into what was going wrong and cooked this patch. If
> someone has any suggestions of what I need to do to work around this,
> let me know.
>
>
I met the same problem and there should be no difference when not using
the static build.
>>> Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
>>> ---
>>> client/tests/monotonic_time/src/Makefile | 1 -
>>> 1 files changed, 0 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/client/tests/monotonic_time/src/Makefile b/client/tests/monotonic_time/src/Makefile
>>> index 56aa7b6..2121ec4 100644
>>> --- a/client/tests/monotonic_time/src/Makefile
>>> +++ b/client/tests/monotonic_time/src/Makefile
>>> @@ -1,7 +1,6 @@
>>> CC= cc
>>>
>>> CFLAGS= -O -std=gnu99 -Wall
>>> -LDFLAGS=-static
>>> LIBS= -lpthread -lrt
>>>
>>> PROG= time_test
>>> --
>>> 1.6.6.1
>>>
>>> _______________________________________________
>>> Autotest mailing list
>>> Autotest@test.kernel.org
>>> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>>>
>>>
>> _______________________________________________
>> Autotest mailing list
>> Autotest@test.kernel.org
>> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>>
>>
>
>
>
>
prev parent reply other threads:[~2010-03-24 1:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 18:13 [PATCH] Monotonic time test: Don't force static compilation of time_test Lucas Meneghel Rodrigues
2010-03-23 18:25 ` Martin Bligh
2010-03-23 20:13 ` Michael Davidson
2010-03-23 20:56 ` [Autotest] " Lucas Meneghel Rodrigues
2010-03-23 21:15 ` Martin Bligh
2010-03-24 1:16 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA967EE.1080900@redhat.com \
--to=jasowang@redhat.com \
--cc=autotest@test.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lmr@redhat.com \
--cc=mbligh@google.com \
--cc=md@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox