Re: [Autotest] [PATCH 2/4] KVM test: Add TSC into guest test

[Jason Wang <jasowang@redhat.com>]

Lucas Meneghel Rodrigues wrote:
> On Mon, Mar 22, 2010 at 4:45 AM, Jason Wang <jasowang@redhat.com> wrote:
>   
>> TSC is used to check the whether the TSC of processors are
>> synchronized which is useful for testing virtual TSC.
>>     
>
> The only thing that needs to be corrected here is that this test needs
> -smp > 1 to work (actually, even numbers work better), so I'll make
> it not available with -smp 1. Thanks for the patch, I am going to put
> it upstream soon!
>
>   
I agree, and maybe we'd better also use smp > 1 in the test of 
monotonic_time ?
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> ---
>>  client/tests/kvm/autotest_control/tsc.control |   13 +++++++++++++
>>  client/tests/kvm/tests_base.cfg.sample        |    3 +++
>>  2 files changed, 16 insertions(+), 0 deletions(-)
>>  create mode 100644 client/tests/kvm/autotest_control/tsc.control
>>
>> diff --git a/client/tests/kvm/autotest_control/tsc.control b/client/tests/kvm/autotest_control/tsc.control
>> new file mode 100644
>> index 0000000..0c1c65a
>> --- /dev/null
>> +++ b/client/tests/kvm/autotest_control/tsc.control
>> @@ -0,0 +1,13 @@
>> +NAME = 'Check TSC'
>> +AUTHOR = 'Michael Davidson <md@google.com>'
>> +TIME = 'MEDIUM'
>> +TEST_CLASS = 'Kernel'
>> +TEST_CATEGORY = 'Functional'
>> +TEST_TYPE = 'client'
>> +DOC = """
>> +checktsc is a user space program that checks TSC synchronization
>> +between pairs of CPUs on an SMP system using a technique borrowed
>> +from the Linux 2.6.18 kernel.
>> +"""
>> +
>> +job.run_test('tsc')
>> diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample
>> index 2af6a05..861759e 100644
>> --- a/client/tests/kvm/tests_base.cfg.sample
>> +++ b/client/tests/kvm/tests_base.cfg.sample
>> @@ -136,6 +136,9 @@ variants:
>>             - monotonic_time:
>>                 test_name = monotonic_time
>>                 test_control_file = monotonic_time.control
>> +            - tsc:
>> +                test_name = tsc
>> +                test_control_file = tsc.control
>>
>>     - linux_s3:     install setup unattended_install
>>         type = linux_s3
>>
>> _______________________________________________
>> Autotest mailing list
>> Autotest@test.kernel.org
>> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>>
>>     
>
>
>
>