public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, kvm@vger.kernel.org
Subject: Re: [KVM PATCH] pci passthrough: zap option rom scanning.
Date: Wed, 24 Mar 2010 15:21:32 +0100	[thread overview]
Message-ID: <4BAA1FEC.807@suse.de> (raw)
In-Reply-To: <20100121161825.GC3750@amt.cnet>

Marcelo Tosatti wrote:
> On Wed, Jan 20, 2010 at 11:58:48AM +0100, Gerd Hoffmann wrote:
>   
>> Nowdays (qemu 0.12) seabios loads option roms from pci rom bars.  So
>> there is no need any more to scan for option roms and have qemu load
>> them.  Zap the code.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>>     
>
> Applied, thanks.
>   

Without this patch (0.12.3) I get the following error message when
trying to pass 2 functions of an ixgbe adapter to the guest:

falla:/abuild/agraf/qemu-kvm/:[0]# qemu-kvm -pcidevice host=07:00.0
-pcidevice host=07:00.1 -nographic -append console=ttyS0 -kernel
/boot/vmlinuz.x -initrd /boot/initrd.x
device: 07:00.0: driver="pci-assign" host="07:00.0"
device: 07:00.1: driver="pci-assign" host="07:00.1"
rom: requested regions overlap (rom 07:00.1. free=0x000000000000ac00,
addr=0x0000000000000000)
rom loading failed


The same code works with qemu-kvm.git. Cherry picking this commit
(51c0dad5ce383be94ca7c46e491ada17cc9ec416) also makes it work in
0.12-stable.


Thus I'd incline we also take this patch into 0.12-stable.


Alex



  reply	other threads:[~2010-03-24 14:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-20 10:58 [KVM PATCH] pci passthrough: zap option rom scanning Gerd Hoffmann
2010-01-21 16:18 ` Marcelo Tosatti
2010-03-24 14:21   ` Alexander Graf [this message]
2010-03-25 16:19     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BAA1FEC.807@suse.de \
    --to=agraf@suse.de \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox