From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [KVM PATCH] pci passthrough: zap option rom scanning. Date: Wed, 24 Mar 2010 15:21:32 +0100 Message-ID: <4BAA1FEC.807@suse.de> References: <1263985128-5772-1-git-send-email-kraxel@redhat.com> <20100121161825.GC3750@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Gerd Hoffmann , kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from cantor.suse.de ([195.135.220.2]:54258 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756369Ab0CXOVe (ORCPT ); Wed, 24 Mar 2010 10:21:34 -0400 In-Reply-To: <20100121161825.GC3750@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > On Wed, Jan 20, 2010 at 11:58:48AM +0100, Gerd Hoffmann wrote: > >> Nowdays (qemu 0.12) seabios loads option roms from pci rom bars. So >> there is no need any more to scan for option roms and have qemu load >> them. Zap the code. >> >> Signed-off-by: Gerd Hoffmann >> > > Applied, thanks. > Without this patch (0.12.3) I get the following error message when trying to pass 2 functions of an ixgbe adapter to the guest: falla:/abuild/agraf/qemu-kvm/:[0]# qemu-kvm -pcidevice host=07:00.0 -pcidevice host=07:00.1 -nographic -append console=ttyS0 -kernel /boot/vmlinuz.x -initrd /boot/initrd.x device: 07:00.0: driver="pci-assign" host="07:00.0" device: 07:00.1: driver="pci-assign" host="07:00.1" rom: requested regions overlap (rom 07:00.1. free=0x000000000000ac00, addr=0x0000000000000000) rom loading failed The same code works with qemu-kvm.git. Cherry picking this commit (51c0dad5ce383be94ca7c46e491ada17cc9ec416) also makes it work in 0.12-stable. Thus I'd incline we also take this patch into 0.12-stable. Alex