From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [Autotest] [PATCH 2/4] KVM test: Add TSC into guest test Date: Fri, 26 Mar 2010 10:51:37 +0800 Message-ID: <4BAC2139.9010606@redhat.com> References: <20100322074452.16119.22820.stgit@localhost.localdomain> <20100322074501.16119.41851.stgit@localhost.localdomain> <6ac58f4f1003232237n52888c60w8c7c2264cfbc72d3@mail.gmail.com> <4BA9AA25.5020800@redhat.com> <6ac58f4f1003240743qc938be9g5997e574001d69da@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: autotest@test.kernel.org, kvm@vger.kernel.org To: Lucas Meneghel Rodrigues Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46864 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893Ab0CZCvo (ORCPT ); Thu, 25 Mar 2010 22:51:44 -0400 In-Reply-To: <6ac58f4f1003240743qc938be9g5997e574001d69da@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: Lucas Meneghel Rodrigues wrote: > On Wed, Mar 24, 2010 at 2:59 AM, Jason Wang wrote: > >> Lucas Meneghel Rodrigues wrote: >> >>> On Mon, Mar 22, 2010 at 4:45 AM, Jason Wang wrote: >>> >>> >>>> TSC is used to check the whether the TSC of processors are >>>> synchronized which is useful for testing virtual TSC. >>>> >>>> >>> The only thing that needs to be corrected here is that this test needs >>> -smp > 1 to work (actually, even numbers work better), so I'll make >>> it not available with -smp 1. Thanks for the patch, I am going to put >>> it upstream soon! >>> >>> >>> >> I agree, and maybe we'd better also use smp > 1 in the test of >> monotonic_time ? >> > > Monotonic time has not this restriction, as far as I know... Unless I > am very mistaken > > Yes, it does not have such restriction, but I think it would be more reasonable to do the test in smp > 2 especially for kvmclock as it depends on per-vcpu data structure and guest tsc which may have more problems during the vcpu migration between physical processors. >>>> Signed-off-by: Jason Wang >>>> --- >>>> client/tests/kvm/autotest_control/tsc.control | 13 +++++++++++++ >>>> client/tests/kvm/tests_base.cfg.sample | 3 +++ >>>> 2 files changed, 16 insertions(+), 0 deletions(-) >>>> create mode 100644 client/tests/kvm/autotest_control/tsc.control >>>> >>>> diff --git a/client/tests/kvm/autotest_control/tsc.control b/client/tests/kvm/autotest_control/tsc.control >>>> new file mode 100644 >>>> index 0000000..0c1c65a >>>> --- /dev/null >>>> +++ b/client/tests/kvm/autotest_control/tsc.control >>>> @@ -0,0 +1,13 @@ >>>> +NAME = 'Check TSC' >>>> +AUTHOR = 'Michael Davidson ' >>>> +TIME = 'MEDIUM' >>>> +TEST_CLASS = 'Kernel' >>>> +TEST_CATEGORY = 'Functional' >>>> +TEST_TYPE = 'client' >>>> +DOC = """ >>>> +checktsc is a user space program that checks TSC synchronization >>>> +between pairs of CPUs on an SMP system using a technique borrowed >>>> +from the Linux 2.6.18 kernel. >>>> +""" >>>> + >>>> +job.run_test('tsc') >>>> diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample >>>> index 2af6a05..861759e 100644 >>>> --- a/client/tests/kvm/tests_base.cfg.sample >>>> +++ b/client/tests/kvm/tests_base.cfg.sample >>>> @@ -136,6 +136,9 @@ variants: >>>> - monotonic_time: >>>> test_name = monotonic_time >>>> test_control_file = monotonic_time.control >>>> + - tsc: >>>> + test_name = tsc >>>> + test_control_file = tsc.control >>>> >>>> - linux_s3: install setup unattended_install >>>> type = linux_s3 >>>> >>>> _______________________________________________ >>>> Autotest mailing list >>>> Autotest@test.kernel.org >>>> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest >>>> >>>> >>>> >>> >>> >>> >> _______________________________________________ >> Autotest mailing list >> Autotest@test.kernel.org >> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest >> >> > > > >