From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC PATCH 0/7] Beginning implementing the AMD IOMMU emulation Date: Wed, 31 Mar 2010 08:38:43 +0300 Message-ID: <4BB2DFE3.50607@redhat.com> References: <20100330194056.GB24846@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Eduard - Gabriel Munteanu , aliguori@us.ibm.com, qemu-devel@nongnu.org, kvm@vger.kernel.org To: Joerg Roedel Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50158 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757100Ab0CaFjC (ORCPT ); Wed, 31 Mar 2010 01:39:02 -0400 In-Reply-To: <20100330194056.GB24846@8bytes.org> Sender: kvm-owner@vger.kernel.org List-ID: On 03/30/2010 10:40 PM, Joerg Roedel wrote: > >> In short, this demonstrates a mechanism of inserting ACPI tables without >> modifying SeaBIOS or other BIOS implementations. I also have a SeaBIOS >> equivalent, but I think this approach is better, at least at the moment. >> > I like the approach implemented in this patchset because of its > simplicity. The right place for building acpi tables is the bios, > though. I am fine with both ways. Anthony, Avi, what do you > think about it? > I agree. Let qemu emulate the hardware, build the tables in the BIOS. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.