From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] KVM MMU: record reverse mapping for spte only if it's writable Date: Thu, 01 Apr 2010 14:54:36 +0300 Message-ID: <4BB4897C.6030409@redhat.com> References: <4BB45E65.2040006@cn.fujitsu.com> <4BB45EE2.3010000@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , KVM list , LKML To: Xiao Guangrong Return-path: In-Reply-To: <4BB45EE2.3010000@cn.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 04/01/2010 11:52 AM, Xiao Guangrong wrote: > The read only spte mapping can't hurt shadow page cache, > so, no need to record it. > > We do need to keep track of read-only mappings, that's how swapping works. See commit ca335c8f08d. -- error compiling committee.c: too many arguments to function